Allow GitHub Action to run on Windows #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scratch that, MacOS doesn't like the syntax. Looks like I'll be bringing back the duplication. |
alcaeus
force-pushed
the
fix-action-windows
branch
from
cff0bb1
to
b97deae
Compare
alcaeus
force-pushed
the
fix-action-windows
branch
3 times, most recently
from
f6b2fb8
to
9f56eee
Compare
alcaeus
force-pushed
the
fix-action-windows
branch
from
9f56eee
to
b75b51e
Compare
Changing the shebang to bash fixed the issue, so I was able to get this done without duplication. The PR is now ready for review, I added Windows to the test matrix here on GHA to protect against regressions. |
adriandole
pushed a commit
to adriandole/drivers-evergreen-tools
that referenced
this pull request
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some changes to the orchestration action and involved scripts to allow them to run on Windows.
To reduce duplication in the download script, I've combined Windows and cygwin through a fallback, however since PHP does its Windows testing in GitHub Actions I'd appreciate it if someone could double-check that the
casestatement is still valid. It doesn't throw a syntax error, so that's a start. When running on Windows in GitHub Actions, the OS identifier ismingw64_nt-<version>-x86_64. Since the path to the extraction tools doesn't match the path used on cygwin, I had to duplicate the config. However, since 7zip is in the PATH on Windows, we might be able to reduce duplication again if it's in the PATH on cygwin as well. Again, can't test this since I don't have any Evergreen tasks on Windows.The action needed a couple of changes, and I also added an output variable for the
crypt_sharedpath, which is necessary for us to run tests in. I used the cygwin logic to kill processes on Windows, but wasn't able to test this as the orchestration isn't running in a build. Here's a sample build in PHPC that used the new action version: https://github.com/alcaeus/mongo-php-driver/actions/runs/9958433378/job/27559930163